Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label when no result in simple view history and orders #1294

Merged
5 commits merged into from
Sep 16, 2021

Conversation

ghost
Copy link

@ghost ghost commented Sep 15, 2021

Closes #1284

@ghost ghost requested a review from smk762 September 15, 2021 13:47
@smk762
Copy link
Collaborator

smk762 commented Sep 16, 2021

I see this working on simple view filters, but not on Pro view filters.

@ghost
Copy link
Author

ghost commented Sep 16, 2021

I see this working on simple view filters, but not on Pro view filters.

Added in latest commit

@ghost ghost merged commit 9c2f9e5 into dev Sep 16, 2021
@smk762 smk762 deleted the add_label_when_no_result_in_simple_view_history_and_orders branch November 7, 2021 13:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Add "No results found" text in case of empty filter result
1 participant