Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better coin type readability in enable modal #1296

Merged
merged 3 commits into from
Sep 16, 2021
Merged

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Sep 16, 2021

Resolves #1255

@smk762 smk762 requested review from a user and tonymorony September 16, 2021 05:19
tonymorony
tonymorony previously approved these changes Sep 16, 2021
Copy link
Contributor

@tonymorony tonymorony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghost
Copy link

ghost commented Sep 16, 2021

I think UTXO text color might be enhanced:

Capture d’écran 2021-09-16 à 12 50 18 PM

Other than that code's looking good to me.

@smk762
Copy link
Collaborator Author

smk762 commented Sep 16, 2021

I think UTXO text color might be enhanced:

Capture d’écran 2021-09-16 à 12 50 18 PM

Other than that code's looking good to me.

tweaked colors a bit more using eyedropper tool to match figma

image

@tonymorony tonymorony self-requested a review September 16, 2021 13:33
@tonymorony tonymorony merged commit eceef88 into dev Sep 16, 2021
@tonymorony tonymorony deleted the coinType_contrast branch September 16, 2021 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Better contrast for coin type in enable menu (lite mode)
2 participants