Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add refund countdown #1716

Merged
merged 3 commits into from Jun 16, 2022
Merged

add refund countdown #1716

merged 3 commits into from Jun 16, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Apr 4, 2022

closes #620

@smk762 smk762 marked this pull request as draft April 4, 2022 12:47
@smk762
Copy link
Collaborator Author

smk762 commented May 6, 2022

To test this quicker, you can build mm2 from source with cargo build --features custom-swap-locktime
See KomodoPlatform/komodo-defi-framework#1252
Then copy this mm2 to overwrite your local one in a portable CI build

If using the custom mm2, it needs to be running on both the maker and taker instances, otherwise there will be a "negtiate failed" error. I can put up some maker orders with the custom mm2 and/or provide testcoins if needed, just contact me on discord/keybase.

cipig
cipig previously approved these changes May 7, 2022
Canialon
Canialon previously approved these changes May 11, 2022
cipig
cipig previously approved these changes May 14, 2022
atomic_defi_design/Dex/Components/DefaultModal.qml Outdated Show resolved Hide resolved
atomic_defi_design/Dex/Components/DefaultModal.qml Outdated Show resolved Hide resolved
atomic_defi_design/Dex/Components/DexBusyIndicator.qml Outdated Show resolved Hide resolved
atomic_defi_design/Dex/Components/DexBusyIndicator.qml Outdated Show resolved Hide resolved
atomic_defi_design/Dex/Components/DexCheckBox.qml Outdated Show resolved Hide resolved
atomic_defi_design/Dex/Components/DexScrollView.qml Outdated Show resolved Hide resolved
atomic_defi_design/Dex/Components/DexScrollView.qml Outdated Show resolved Hide resolved
atomic_defi_design/Dex/Components/DexScrollView.qml Outdated Show resolved Hide resolved
@smk762 smk762 requested a review from a user June 1, 2022 09:39
@smk762 smk762 requested a review from a user June 7, 2022 02:34
cipig
cipig previously approved these changes Jun 11, 2022
ghost
ghost previously approved these changes Jun 12, 2022
@ghost ghost dismissed stale reviews from cipig and themself via 4733d71 June 15, 2022 08:58
@smk762 smk762 requested review from a user, cipig and Canialon June 15, 2022 09:04
@smk762 smk762 merged commit 956e29e into dev Jun 16, 2022
@tonymorony tonymorony mentioned this pull request Jun 21, 2022
@ghost ghost deleted the refund_countdown branch September 15, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST]: Let a maker know the time left till a stuck MakerPayment can be refunded
4 participants