Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Calendar style #1780

Merged
5 commits merged into from Jun 6, 2022
Merged

Change Calendar style #1780

5 commits merged into from Jun 6, 2022

Conversation

ghost
Copy link

@ghost ghost commented May 29, 2022

@ghost ghost requested review from smk762 and Canialon May 29, 2022 13:11
@ghost ghost marked this pull request as ready for review May 29, 2022 13:12
Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no overflows or weird animation detected here on linux. Is it possible to change colors to match the rest of the app?

@Canialon
Copy link
Contributor

@SylEze could you apply these changes to the simple mod as well? ^^

image


Also, there are a few small fixes:

  • change the color of arrows for a light theme
    IMAGE 2022-05-29 18:20:56

  • fix alignment for shower effect

Screenshot 2022-05-29 at 18 06 01

Screenshot 2022-05-29 at 18 06 19

tested on macOS, later will recheck on Windows

@ghost ghost requested a review from smk762 May 30, 2022 09:36
@ghost
Copy link
Author

ghost commented May 30, 2022

^ @Canialon @smk762

@smk762
Copy link
Collaborator

smk762 commented May 30, 2022

I like the new colors - couple of quirks tho:

  • no hover effect on lite mode over dates or top arrows.
  • no hover effect on dark mode over dates.
  • no "current date" tooltip

@ghost
Copy link
Author

ghost commented Jun 3, 2022

* no "current date" tooltip

Let's not add it for the moment, I think it was not there before ?

@ghost
Copy link
Author

ghost commented Jun 3, 2022

I like the new colors - couple of quirks tho:

* no hover effect on lite mode over dates or top arrows.

* no hover effect on dark mode over dates.

Fixed! @Canialon @smk762

@tonymorony tonymorony self-requested a review June 6, 2022 12:03
@ghost ghost merged commit 6649f29 into dev Jun 6, 2022
@tonymorony tonymorony mentioned this pull request Jun 21, 2022
@ghost ghost deleted the calendar branch September 15, 2022 10:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: weird calendar
3 participants