Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show protocol in order form #1788

Merged
5 commits merged into from Jun 14, 2022
Merged

show protocol in order form #1788

5 commits merged into from Jun 14, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jun 12, 2022

Closes #1462
Also fixed issue where previously sometimes fiat values at bottom of form became misaligned.

@smk762 smk762 requested review from a user, tonymorony, cipig and Canialon June 12, 2022 06:28
cipig
cipig previously approved these changes Jun 14, 2022
View reviewed changes
@ghost ghost requested a review from cipig June 14, 2022 12:11
@ghost ghost merged commit ef9e039 into dev Jun 14, 2022
cipig added a commit to cipig/atomicDEX-Desktop that referenced this pull request Jun 15, 2022
@cipig
Revert "Merge pull request KomodoPlatform#1788 from KomodoPlatform/sh…
21cf2be 
…ow_protocol"

This reverts commit ef9e039, reversing
changes made to 6649f29.
@tonymorony tonymorony mentioned this pull request Jun 21, 2022
Merged
@ghost ghost deleted the show_protocol branch September 15, 2022 10:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@tonymorony tonymorony Awaiting requested review from tonymorony

@Canialon Canialon Awaiting requested review from Canialon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: for confusing when doing cross protocol swaps of same coin
2 participants
@smk762 @cipig