Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fields content were not correctly centered #1836

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 1, 2022

Closes #1800

Note: please test as many existing input fields as you can because this PR modifies the base component itself

@ghost ghost requested review from smk762 and Canialon July 1, 2022 10:49
@smk762
Copy link
Collaborator

smk762 commented Jul 1, 2022

The only misalignment I found so far is this
image
Though that is alignment between components, not within the same one.

Copy link
Contributor

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it seems to fix initial issue at least. )

@smk762 smk762 merged commit fc8ed9f into dev Jul 4, 2022
@ghost ghost deleted the fix_input_field_alignment branch September 15, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI]: Input field alignment
4 participants