Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix overflow, binding loop and cmake syntax #1853

Merged
11 commits merged into from Jul 13, 2022
Merged

fix overflow, binding loop and cmake syntax #1853

11 commits merged into from Jul 13, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jul 5, 2022

  • closes [BUG]: Overflow in addressbook #1852
  • resolves [18:09:35] [warning] [main.prerequisites.hpp:92] [3237681]: qrc:/Dex/Addressbook/AddAddressForm.qml:113:13: QML AddressTypeSelector: Binding loop detected for property "implicitHeight"
  • resolves quote syntax error in cmake post install

@smk762 smk762 requested review from a user, tonymorony, cipig, SirSevenG and Canialon July 5, 2022 10:36
@cipig
Copy link
Member

cipig commented Jul 5, 2022

not sure if related to this, i usually don't use addressbook
anyway, if i try to add a new contact and get to this form
image
every time i try to change the coin like this
image
(selecting LTC from the search results)
i get this error on console

[16:08:27] [warning] [main.prerequisites.hpp:92] [2366618]: qrc:/Dex/Addressbook/AddressTypeSelector.qml:62:13: Unable to assign [undefined] to QString

and the coin is not changed

@cipig
Copy link
Member

cipig commented Jul 7, 2022

[23:07:49] [warning] [main.prerequisites.hpp:92] [2743785]: qrc:/Dex/Addressbook/AddAddressForm.qml:113:13: QML AddressTypeSelector: Binding loop detected for property "implicitHeight"

and when i try to change coin i get this

[23:08:09] [warning] [main.prerequisites.hpp:92] [2743785]: qrc:/Dex/Addressbook/AddressTypeSelector.qml:62:13: Unable to assign [undefined] to QString

@smk762 smk762 requested a review from a user July 11, 2022 07:36
syl added 2 commits July 11, 2022 13:00
…illed

Reproducing steps: Select the first entry -> type any keyword in the field that matches at least two entries -> try to select the second entry
ghost
ghost previously approved these changes Jul 11, 2022
Canialon
Canialon previously approved these changes Jul 11, 2022
@cipig
Copy link
Member

cipig commented Jul 11, 2022

getting this when i try to add a new address to an existing contact
image
in this case it's DGB, but DGB is already enabled

@smk762
Copy link
Collaborator Author

smk762 commented Jul 12, 2022

getting this when i try to add a new address to an existing contact in this case it's DGB, but DGB is already enabled

I get the same, only for individual coins (network standard is ok). @SylEze seems to be related to your most recent commits.
working: https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/2635869147
not working: https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/2649191429

@ghost ghost dismissed stale reviews from Canialon and themself via fc77c83 July 12, 2022 10:52
@ghost ghost requested review from Canialon and a user July 12, 2022 10:52
@ghost
Copy link

ghost commented Jul 12, 2022

Fixed @cipig @smk762

ghost
ghost previously approved these changes Jul 12, 2022
SirSevenG
SirSevenG previously approved these changes Jul 12, 2022
Copy link
Contributor

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smk762
Copy link
Collaborator Author

smk762 commented Jul 12, 2022

One last issue @SylEze

no-disabled-parents.mp4

@ghost ghost dismissed stale reviews from SirSevenG and themself via 4c4c306 July 12, 2022 12:01
@ghost ghost requested a review from SirSevenG July 12, 2022 12:15
@ghost
Copy link

ghost commented Jul 12, 2022

Oopsie, fixed again
@smk762

@smk762 smk762 requested a review from a user July 12, 2022 12:30
@smk762
Copy link
Collaborator Author

smk762 commented Jul 12, 2022

Thanks, looks good now 👍

@ghost ghost merged commit 135796b into dev Jul 13, 2022
@smk762 smk762 deleted the abook_oflow branch August 7, 2023 07:40
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Overflow in addressbook
4 participants