Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide explorer link if fresh wallet #1874

Merged
merged 2 commits into from
Jul 22, 2022
Merged

hide explorer link if fresh wallet #1874

merged 2 commits into from
Jul 22, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Jul 15, 2022

Closes: #1867

To Test:

  • You should see a link for AVAX and AVX20 tokens, as we can't get history or them yet.
  • For general utxo coins, for wallet where you have no balance or transactions, you will not see a link.

@smk762 smk762 requested review from a user, tonymorony, SirSevenG and Canialon July 15, 2022 18:00
@Canialon
Copy link
Contributor

Should this link be removed? It still appears for me
image
I tried CI builds for mac and windows

SirSevenG
SirSevenG suggested changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@SirSevenG SirSevenG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, looks same for me (fresh wallet)
image
image

@smk762
Copy link
Collaborator Author

smk762 commented Jul 18, 2022

I think it is fixed now - ignore AVAX, it actually does show history if available.

After this fix, you should only see the link on:

  • Ubiq (UBQ)
  • KuCoin (KCS)
  • Harmony (ONE)
  • SmartBCH (SBCH)

@smk762 smk762 requested a review from SirSevenG July 18, 2022 11:46
@tonymorony tonymorony merged commit f0ac671 into dev Jul 22, 2022
@smk762 smk762 deleted the notx branch August 7, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonymorony tonymorony tonymorony approved these changes

@SirSevenG SirSevenG SirSevenG approved these changes

@Canialon Canialon Canialon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Link to explorer displaying in every case when there is no transactions for asset
4 participants
@smk762 @Canialon @tonymorony @SirSevenG