Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rewards modal overflows + make it more theme friendly #1877

Merged
merged 1 commit into from Jul 26, 2022
Merged

Fix rewards modal overflows + make it more theme friendly #1877

merged 1 commit into from Jul 26, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 18, 2022

Closes #1869
Closes #1848

@ghost ghost added the next iteration to not forget to include it label Jul 18, 2022
@ghost ghost requested review from smk762 and Canialon July 18, 2022 11:25
smk762
smk762 approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@smk762 smk762 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but if we can get it on to one line would be better.
image

I'd suggest locktime not set (is) and a small reduction of other columns (or column margin/padding). Might still be an overflow for other languages tho...

image

Heh, nevermind.

@ghost
Copy link
Author

ghost commented Jul 20, 2022 •
edited by ghost

Works, but if we can get it on to one line would be better. image

I'd suggest locktime not set (is) and a small reduction of other columns (or column margin/padding). Might still be an overflow for other languages tho...

image

Heh, nevermind.

Let's modernize rewards for another pr, I think we can do something better (cf. #1661)

@tonymorony tonymorony merged commit cbfc300 into dev Jul 26, 2022
@smk762 smk762 deleted the fix_rewards_modal branch August 7, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canialon Canialon Awaiting requested review from Canialon

Assignees
No one assigned
Labels
next iteration to not forget to include it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Text overflow on the Rewards window [BUG]: standardise line thickness in rewards modal
3 participants
@tonymorony @smk762 @SirSevenG