add form shortcuts, min vol input

[smk762]

closes: #1941
closes: #1459

orderform_update.mp4

[tonymorony]

Thats a great feature, thank you!

1. I've noticed that inaccuracy accumulating when I press +1% (I assume it should be around 8% when I click 8 times but it's 8.32% what is quite huge diff)

Screen.Recording.2022-08-25.at.14.45.14.mov

2. For a new user it might be not clear what -1% 0% 1% buttons means, it would be awesome to add a tooltip with clarification

[tonymorony]

^^ it worth to double-check calculations, seems to be not precise

[smk762]

^^ it worth to double-check calculations, seems to be not precise

At the moment, the +1% is relative to currently input price, so it is compounding.
If you think its better to make it a consistent 1% relative to market, I can change that easy enough.

The only problem with this is if the coin has no cex price to calculate from. In this case, I can revert to compounding relative to price input field.

[tonymorony]

^^ it worth to double-check calculations, seems to be not precise

At the moment, the +1% is relative to currently input price, so it is compounding. If you think its better to make it a consistent 1% relative to market, I can change that easy enough.

The only problem with this is if the coin has no cex price to calculate from. In this case, I can revert to compounding relative to price input field.

It depends on how these buttons should act:

0% button now setting price same as CEX, if -1% and +1% operating with price in field it's a bit inconsistent/confusing imo (at least without additional clarification for the user, e.g. I've expected that -1% +1% setting price 1% better or worse vs CEX price)

[smk762]

non-compounding is more intuitive, tho with tooltip explaining the compounding way for both priced and unpriced would be more consistent (otherwise long tooltip with conditionals).

Another alternative could be to remove those buttons for unpriced pairs (right now clicking the zero on an unpriced coin is pointless)

[tonymorony]

non-compounding is more intuitive, tho with tooltip explaining the compounding way for both priced and unpriced would be more consistent (otherwise long tooltip with conditionals).

Another alternative could be to remove those buttons for unpriced pairs (right now clicking the zero on an unpriced coin is pointless)

maybe we should use both? (don't show buttons for assets without CEX price and in case if they showing show a ? tooltip with explanation

[Canialon]

@smk762 this tip is a good idea, but they covered the field with information. So to see how the amount changed in this field I need to move out the mouse every time. Can you please replace the tips on the bottom of the buttons? I hope it will be better

---

I can set a negative price if I enter 0 and click the -1 button

Anyway, this swap will fail because of minimum price( [{"error":"rpc:212] dispatcher_legacy:160] lp_ordermatch:3565] lp_ordermatch:3646] Price is too low, minimum is 0.00000001"}] ). But I guess it would be good to eliminate the possibility of setting a negative value

[tonymorony]

found a bug I think:
I can see "Min volume" I've input when I deactivate "Use custom minimum trade amount" - I assume min trade volume shouldn't apply if deactivated:

Screen.Recording.2022-08-31.at.17.45.24.mov

[tonymorony]

would be great to fix ^^

[smk762]

I've also made the form stop bouncing around when you toggle the min volume field, get an error message or the "Order selected" box is displayed. Previously, when these became visible, it would shift other form elements - now everything should stay where it is when these things change between visible or hidden.