Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors gracefully #1954

Merged
merged 2 commits into from Sep 2, 2022
Merged

Handle errors gracefully #1954

merged 2 commits into from Sep 2, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Sep 1, 2022

On login, sometimes prices are not yet available and this error floods the logs
image

This PR handles the error without an exception log message.

There was another "on launch" error relating to app update status, it was due to a misspelled variable, which is also fixed in this PR.

@smk762 smk762 marked this pull request as draft September 1, 2022 08:59
@smk762 smk762 marked this pull request as ready for review September 1, 2022 09:20
@smk762 smk762 merged commit ddcf8f8 into dev Sep 2, 2022
@smk762 smk762 mentioned this pull request Nov 18, 2022
@smk762 smk762 deleted the suppress_json_err branch August 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants