Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change checkbox style #2160

Merged
merged 4 commits into from Dec 7, 2022
Merged

Change checkbox style #2160

merged 4 commits into from Dec 7, 2022

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Dec 6, 2022

Requested by whitelabel project.

Before:
image

After:
image

To Test:

  • Check all checkboxes are displayed as the new style
  • Confirm checkbox size is appropriate next it's label
  • Confirm no label overflow etc as result of change

@smk762 smk762 requested review from a user, tonymorony, SirSevenG and Canialon December 6, 2022 17:00
@Canialon
Copy link
Contributor

Canialon commented Dec 6, 2022

after changes there appeared an overflow at addressbook->contact window->

image

@Canialon
Copy link
Contributor

Canialon commented Dec 6, 2022 •
edited

  • accept disclaimer and tos
  • portfolio -> show coins with balance
  • enable assets window
  • DEX -> PRO -> use custom minimum trade amount
  • confirm exchange details page -> use custom protection
  • Address book -> contact -> add address -> use standard network address
  • custom seed phrase

ghost
ghost suggested changes Dec 6, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The white_check.svg might not fit for certain themes

We can add a new checkBoxCheckColor property inside theme structure to fix that

@smk762 smk762 requested a review from a user December 7, 2022 09:04
@smk762 smk762 merged commit ce7eb8b into dev Dec 7, 2022
@smk762 smk762 mentioned this pull request Mar 6, 2023
Merged
@smk762 smk762 deleted the tweak_checkbox branch August 7, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Canialon Canialon Canialon approved these changes

@tonymorony tonymorony Awaiting requested review from tonymorony

@SirSevenG SirSevenG Awaiting requested review from SirSevenG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smk762 @Canialon