Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement debug builds for windows #2219

Merged
merged 4 commits into from Mar 27, 2023
Merged

Reimplement debug builds for windows #2219

merged 4 commits into from Mar 27, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 4, 2023

CI was missing a variable for the windows matrix.
To test:

  • confirm launch on windows with release & debug builds.

@smk762
Copy link
Collaborator Author

smk762 commented Mar 5, 2023

Defer testing until #2221 merged into dev

@SirSevenG
Copy link
Contributor

Debug build fails to run with:
pplx task error: WinHttpSendRequest: 12007: The server name or address could not be resolved
Firewall rules does not seem to help here, might be missing something in local env.

Release build works just fine.

@smk762
Copy link
Collaborator Author

smk762 commented Mar 6, 2023

Debug build fails to run with: pplx task error: WinHttpSendRequest: 12007: The server name or address could not be resolved Firewall rules does not seem to help here, might be missing something in local env.

Release build works just fine.

Cheers - I'll check it later for 0.5.8 as it is not a critical fix and we only need release binaries for 0.5.7.1

@smk762 smk762 added the 0.5.8 label Mar 6, 2023
@cipig
Copy link
Member

cipig commented Mar 27, 2023

windows builds with mm2 from the new CI are failing (http://54.170.62.22:8000/dev/mm2_759d180-win-x86-64.zip)

CMake Error: File D:/a/atomicDEX-Desktop/atomicDEX-Desktop/b/_deps/mm2-src/msvcp140.dll does not exist.
CMake Error: File D:/a/atomicDEX-Desktop/atomicDEX-Desktop/b/_deps/mm2-src/vcruntime140.dll does not exist.

those files were included in the mm2 zip of the old CI, but are not included in the zip from new CI

@smk762
Copy link
Collaborator Author

smk762 commented Mar 27, 2023

windows builds with mm2 from the new CI are failing (http://54.170.62.22:8000/dev/mm2_759d180-win-x86-64.zip)

CMake Error: File D:/a/atomicDEX-Desktop/atomicDEX-Desktop/b/_deps/mm2-src/msvcp140.dll does not exist.
CMake Error: File D:/a/atomicDEX-Desktop/atomicDEX-Desktop/b/_deps/mm2-src/vcruntime140.dll does not exist.

those files were included in the mm2 zip of the old CI, but are not included in the zip from new CI

Does the mm2 zip run ok in command line?

@cipig
Copy link
Member

cipig commented Mar 27, 2023

Does the mm2 zip run ok in command line?

idk, i don't have any windows devices to try
i just wanted to make a windows build in my repo and saw this

@smk762
Copy link
Collaborator Author

smk762 commented Mar 27, 2023

It built ok in https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/4342695465/attempts/1
Re-running that workflow now.
Those files should not be required in the mm2 archive, as they are in https://github.com/KomodoPlatform/atomicDEX-Desktop/tree/win_debug_builds/ci_tools_atomic_dex/windows_misc. I've pushed a commit to copy those instead of from the mm2 archive.
workflow - https://github.com/KomodoPlatform/atomicDEX-Desktop/actions/runs/4531547338
commit - 6e83d01

@cipig
Copy link
Member

cipig commented Mar 27, 2023

@smk762 smk762 merged commit cf2eaab into dev Mar 27, 2023
8 checks passed
@smk762 smk762 deleted the win_debug_builds branch August 7, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants