Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API #2230

Merged
merged 37 commits into from
Jun 13, 2023
Merged

Update API #2230

merged 37 commits into from
Jun 13, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Mar 31, 2023

This branch is for updating 0.5.7.x to 0.5.8 once the required methods and changes have been implemented for compatibility with the v1.0.x-beta API.

Closes:

Done:

  • ZHTLC method names and request/response structures updated
  • Resolved a P0 orderbook/bestorders bug which caused crashes due to duplicated uuids in response for segwit coins.
  • Added Tendermint activation
  • Added memo sending for ZHTLC and Tendermint coins

To Test:

  • Activate ZOMBIE, use faucet, send funds, do a swap
  • Activate IRIS, use faucet, send funds with memo (confirm memo on explorer), do a swap
  • Activate ARRR and other tendermint assets
  • Try to crash the pro view orderbook (click on things like a mad man)

You likely will need to do a wallet reset to see IRIS and other new coins.

@smk762 smk762 requested a review from cipig March 31, 2023 15:28
@smk762 smk762 marked this pull request as draft March 31, 2023 15:28
@smk762 smk762 changed the base branch from dev to v0.5.8 March 31, 2023 15:48
@smk762 smk762 mentioned this pull request Apr 1, 2023
@smk762 smk762 removed the request for review from Canialon May 17, 2023 08:22
@endrilickollari
Copy link

  1. Successfully activated ZOMBIE:

image

Sent was successful:

image

Swap was successful:

image

  1. IRIS successfully activated:

image

Transactions history not visible.

Memo visible in explorer view:
image

image

image

Swap was also successful:
image

3.. Tendermint coins successfully activated:
image
while for two coins there is this error:

11 10:05:23, mm2_main::mm2::rpc::dispatcher:113] ERROR RPC error response: platform_coin_with_tokens:314] tendermint_with_assets_activation:191] Error on platform coin OSMO creation: tendermint_coin:2231] tendermint_coin:440] All the current rpc nodes are unavailable.
11 10:05:23, mm2_main::mm2::rpc::dispatcher:113] ERROR RPC error response: platform_coin_with_tokens:314] tendermint_with_assets_activation:191] Error on platform coin ATOM creation: tendermint_coin:2231] tendermint_coin:440] All the current rpc nodes are unavailable.

@smk762 smk762 requested a review from kivqa June 13, 2023 11:33
@smk762 smk762 mentioned this pull request Jun 13, 2023
@smk762 smk762 merged commit 62dda56 into v0.5.8 Jun 13, 2023
7 checks passed
@smk762 smk762 deleted the update_api branch August 7, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants