Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.7.2 Release Candidate #2246

Merged
merged 100 commits into from
Apr 14, 2023
Merged

0.5.7.2 Release Candidate #2246

merged 100 commits into from
Apr 14, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Apr 12, 2023

Please perform the tests below as soon as possible, we aim to release this week to be ready for the airdrop on Friday at midnight.
As this is a minor release, we'll reserve full testplan suite for the 0.5.8 release.
For 0.5.7.2, please focus on testing the following (along with basic smoke testing on all OS)

Changelog:

  • Update version to 0.5.7.2
  • Misc CI/CD updates
  • Updated theme selectors for more extendable theme creation on whitelabels
  • Improved text / background contrast in lite/dark theme modes
  • Added a standardised CancelButton component
  • Improved display of combo selectors in dex pro view
  • Misc other theme tweaks
  • Replaced Nomics chats with LiveCoinWatch charts
  • Used more intuitive red/green buttons for buy/sell in pro view
  • Used more intuitive wording for pro view order form field labels.
  • Reduce log spam (info -> debug)
  • Fixed bug introduced by -segwit coins order uuid duplication in orderbook/bestorders response
  • Misc other minor bug fixes

To Test:

  • Confirm correct app version is on display in settings (0.0.7.2)
  • Confirm launch, login and swap on all OS (installer and portable, release archives only)
  • Check all views for any examples of poor text / background contrast in both lite/dark theme. Screenshot and create an issue for anything found (this is not a blocker so may be resolved in 0.5.8)
  • Check pro view chart display is sane at different window sizes with a variety of pairs. Unsupported pairs shoud show a text warning instead of the chart.
  • Confirm "smart chain" icon is present in addressbook
  • Confirm notifications button changes if no notifications listed
  • Report any crashing! During dev, it seemed more stable since fixing the -segwit uuid duplication bug.

Anything found during testing which is not P0 / P1, please create an issue ticket so it can be fixed in 0.5.8 and not block or delay this release.

@endrilickollari
Copy link

Will cover tests on Windows 10

@Canialon
Copy link
Contributor

will take macOS and Windows 11

@smk762 smk762 requested a review from ca333 April 12, 2023 09:52
Copy link

@endrilickollari endrilickollari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for notifications FR: #2258
Also icon it is okay BUG: #2252

@endrilickollari endrilickollari self-requested a review April 14, 2023 08:30
@Canialon
Copy link
Contributor

Canialon commented Apr 14, 2023

Сan trigger crush on MacOS by activating and deactivating a large number of coins.

On other sides, in terms of everyday smoke use, the app looks good

@smk762
Copy link
Collaborator Author

smk762 commented Apr 14, 2023

Сan trigger crush on MacOS by activating and deactivating a large number of coins.

On other sides, in terms of everyday smoke use, the app looks good

Thanks for the report. VOTE has been airdropped, so will release now and aim for a fix in 0.5.8

@smk762 smk762 merged commit bea819c into master Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants