Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tendermint tx history #2370

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix tendermint tx history #2370

merged 1 commit into from
Sep 22, 2023

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Sep 22, 2023

closes #2368

To test:

  • Log in to wallet with recent ATOM transactions
  • activate ATOM, and open it in wallet page
  • tx history should be visible
  • Check tx history for ZHTLC coins also to confirm no regression.

Note: due to node pruning, older transactions may not be visible.

@smk762 smk762 requested review from cipig and kivqa September 22, 2023 11:00
@smk762 smk762 added the 0.6.2 label Sep 22, 2023
cipig
cipig approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
and ARRR history also still present
image

kivqa
kivqa approved these changes Sep 22, 2023
View reviewed changes
Copy link

@kivqa kivqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.
ATOM txs are displayed correctly (old and new).
ARRR txs history does not have regression in this PR.

@smk762 smk762 merged commit a66cc3a into dev Sep 22, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@kivqa kivqa kivqa approved these changes

Assignees
No one assigned
Labels
0.6.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Tx history is not displayed for ATOM coin
3 participants
@smk762 @cipig @kivqa