v0.7.2 Release Candidate #2459
Merged
v0.7.2 Release Candidate #2459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use windows 2019 runner image
extend to 8dp for portfolio items
Fix menubar currency change
more triggers to scroll asks to bottom in pro orderbook
Add setting to show orders view after placing an order
increment to v0.7.2
|
|
|
|
|
|
|
|
ShantanuSharma9873
approved these changes
Jun 21, 2024
AndrewDelaney
approved these changes
Jun 22, 2024
There was a problem hiding this comment.
All updates made seem to be working correctly. The following items were tested:
- Confirm that portfolio asset values are all 8 decimal places
- Currency display is changed consistently across the platform according to FIAT setting as well as currency set in top menu.
- Orderbook listings top and bottom are scrolled to match one another as close as possible in the following conditions:
- flipping pair
- changing pair
- changing buy/sell mode
- loading dex pro tab
- "Show orders after placement" toggle-setting functions correctly, setting the orders tab to either display after making an order or staying on the chart tab accordingly.
- Version is correctly updated to 0.7.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test all changes from the following PRs:
Also do full regression testing of each page of app to ensure recent changes have not had any unintended consequences.