Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNTP improvements #13

Merged
merged 9 commits into from Nov 28, 2021
Merged

SNTP improvements #13

merged 9 commits into from Nov 28, 2021

Conversation

rfocosi
Copy link
Contributor

@rfocosi rfocosi commented Sep 15, 2019

  • Added retry get time server information, to fix issue on SM-X boot;
  • Timezone is a parameter now (/z);
  • Change on command parameters when a TIMESERVER environment variable is set. Dot(.) is not necessary anymore;

@rfocosi rfocosi closed this Oct 2, 2019
@rfocosi rfocosi reopened this Oct 2, 2019
@rfocosi rfocosi closed this Oct 2, 2019
@rfocosi rfocosi reopened this Oct 2, 2019
@Konamiman
Copy link
Owner

Hi @rfocosi, sorry I hadn't got (or I had missed) notifications for this pull request. I'll take a look.

Konamiman
Konamiman requested changes Nov 27, 2021
View reviewed changes
Copy link
Owner

@Konamiman Konamiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I've just requested a small change in the presentation string.

SRC/NETWORK/sntp.c Outdated Show resolved Hide resolved
SRC/NETWORK/sntp.c Outdated Show resolved Hide resolved
@rfocosi
Copy link
Contributor Author

rfocosi commented Nov 28, 2021

Also, I did a lot of other changes and bugfix in another repository and I will send you another PR after approving this one :)

@Konamiman
SNTP.C: Add pull request link in header
15d813e
@Konamiman
Revert change in .gitignore
6b8aae9 
This change will be added as part of a separate .gitignore file.
@Konamiman Konamiman merged commit dbf5cda into Konamiman:master Nov 28, 2021
@Konamiman
Copy link
Owner

Thanks for your work. I have updated the SNTP tool in my web site with the new v1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Konamiman Konamiman Konamiman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rfocosi @Konamiman