New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradle build script generation for all needed targets #356
Conversation
Signed-off-by: Alex Black <blacka101@gmail.com>
Signed-off-by: Alex Black <blacka101@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For exe: assertTrue(expFile.exists());
is failing for me. The .exe is definitely created under gradle/build/launch4j
; problem is the copyExe task:
Task :createExe
Task :copyExe NO-SOURCE
Maybe windows specific path issues?
rpm, deb, tar, exe and docker are all packing a near-empty JAR not an uber-jar.
We need them to package the uber-jar for any of them to be useful. I've added a size check so the tests now fail
Otherwise: tested and looks pretty good
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/DebDeployment.java
Show resolved
Hide resolved
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/DebDeployment.java
Outdated
Show resolved
Hide resolved
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/DockerDeployment.java
Show resolved
Hide resolved
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/DockerDeployment.java
Show resolved
Hide resolved
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/DockerDeployment.java
Outdated
Show resolved
Hide resolved
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/TarDeployment.java
Outdated
Show resolved
Hide resolved
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/TarDeployment.java
Outdated
Show resolved
Hide resolved
konduit-serving-build/src/test/java/ai/konduit/serving/build/TestGradleGeneration.java
Show resolved
Hide resolved
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/RpmDeployment.java
Outdated
Show resolved
Hide resolved
konduit-serving-build/src/main/java/ai/konduit/serving/build/deployments/RpmDeployment.java
Outdated
Show resolved
Hide resolved
UberJarDeployment is a standalone type. So should we build uberjar implicitly for RpmDeployment? |
Signed-off-by: Alex Black <blacka101@gmail.com>
Signed-off-by: Alex Black <blacka101@gmail.com>
Signed-off-by: Alex Black <blacka101@gmail.com>
Kudos, SonarCloud Quality Gate passed! 6 Bugs 0.0% Coverage The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. |
Implement build script generation for all targets addressed by current maven structure.