Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle build script generation for all needed targets #356

Merged
merged 24 commits into from Jun 17, 2020
Merged

Conversation

alexanderst
Copy link
Contributor

Implement build script generation for all targets addressed by current maven structure.

Copy link
Contributor

@AlexDBlack AlexDBlack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For exe: assertTrue(expFile.exists()); is failing for me. The .exe is definitely created under gradle/build/launch4j; problem is the copyExe task:

Task :createExe
Task :copyExe NO-SOURCE

Maybe windows specific path issues?

rpm, deb, tar, exe and docker are all packing a near-empty JAR not an uber-jar.
We need them to package the uber-jar for any of them to be useful. I've added a size check so the tests now fail

Otherwise: tested and looks pretty good

@alexanderst
Copy link
Contributor Author

rpm, deb, tar, exe and docker are all packing a near-empty JAR not an uber-jar.
We need them to package the uber-jar for any of them to be useful. I've added a size check so the tests now fail

UberJarDeployment is a standalone type. So should we build uberjar implicitly for RpmDeployment?

@alexanderst alexanderst marked this pull request as ready for review June 16, 2020 14:51
Signed-off-by: Alex Black <blacka101@gmail.com>
Signed-off-by: Alex Black <blacka101@gmail.com>
Signed-off-by: Alex Black <blacka101@gmail.com>
Signed-off-by: Alex Black <blacka101@gmail.com>
@AlexDBlack AlexDBlack changed the title [WIP] Gradle build script generation for all needed targets Gradle build script generation for all needed targets Jun 17, 2020
Signed-off-by: Alex Black <blacka101@gmail.com>
Signed-off-by: Alex Black <blacka101@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2020

Kudos, SonarCloud Quality Gate passed!

Bug C 6 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 20 Code Smells

0.0% 0.0% Coverage
20.5% 20.5% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@AlexDBlack AlexDBlack merged commit 315a736 into master Jun 17, 2020
@AlexDBlack AlexDBlack deleted the asto_gradle branch June 17, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants