fix(ingress) disable duplicate CRD installation #1052
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
NissesSenap
force-pushed
the
disable_crd_in_gateway
branch
from
c7559f0
to
54c5404
Compare
|
I don't think this will work, due to templates for CRD don't work in helm 3 if I understand it correctly https://helm.sh/docs/topics/charts/#custom-resource-definitions-crds The issue have popped up a number of times in helm, but no luck. So I'm unsure if there is any way around this. If anyone have a better idea on how to solve it please share. |
|
This won't change anything, so I will close this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove
Which issue this PR fixes
Special notes for your reviewer:
Checklist
mainbranch.