Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admission) add secret filter #1061

Merged
merged 7 commits into from
May 8, 2024
Merged

feat(admission) add secret filter #1061

merged 7 commits into from
May 8, 2024

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Apr 26, 2024

What this PR does / why we need it:

Chart manifest component of Kong/kubernetes-ingress-controller#5856

Removes the secrets entry from the existing webhook.

Adds an ingressController.admissionWebhook.filterSecrets boolean value. When true, it creates webhooks that accept only Secrets with known KIC-relevant labels. When false, it creates a webhook that accepts any (non-Helm) Secret.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@rainest rainest marked this pull request as ready for review April 29, 2024 21:33
@rainest rainest requested a review from a team as a code owner April 29, 2024 21:33
randmonkey
randmonkey previously approved these changes Apr 30, 2024
charts/kong/CHANGELOG.md Outdated Show resolved Hide resolved
@czeslavo
Copy link
Contributor

I've regenerated golden files using the latest version of chartsnap to reduce changes volume: eceadb9

Chartsnap in v0.3.0 changed the format of golden files from TOML to YAML and I adopted this format in #1054. One mistake I made was to not enforce a local version to always match the one defined as desired. This should fix it for the future: #1064.

@rainest rainest requested a review from randmonkey April 30, 2024 21:39
@rainest rainest enabled auto-merge (squash) May 6, 2024 20:12
@rainest rainest requested a review from a team May 7, 2024 22:14
@rainest rainest merged commit 035836a into main May 8, 2024
36 checks passed
@rainest rainest deleted the feat/admission-cred branch May 8, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants