[kong] target proxy with ServiceMonitor selector #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
requested changes
Apr 10, 2020
There was a problem hiding this comment.
Same merge conflict mentioned in #110 (comment)
Could you also use a descriptive lablel? e.g.
enable-metrics: true
versus
foobar-label: enables-metrics
|
Reopening per comment here: #113 (comment) |
This commit limits the ServiceMonitor, so it only targets the proxy Service resource instead of both the proxy and the admin Service.
artburkart
force-pushed
the
servicemonitor-targets-kong-proxy
branch
from
c66a121
to
54231d0
Compare
rainest
approved these changes
Apr 27, 2020
rainest
pushed a commit
that referenced
this pull request
May 27, 2020
This commit limits the ServiceMonitor, so it only targets the proxy Service resource instead of both the proxy and the admin Service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit limits the ServiceMonitor, so it only targets the proxy
Service resource instead of both the proxy and the admin Service.
What this PR does / why we need it:
When we set
serviceMonitor.enabledtotrue, aServiceMonitorresource is created, which targets both the adminServiceand the proxyService. The metrics are identical, which means they're doubled in in Prometheus. This change makes it so theServiceMonitoronly targets the proxyService.Special notes for your reviewer:
I didn't know which label we'd think would be appropriate, and since naming is hard, I opted to throw a strawman label into this PR, so we could discuss what we want here.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
nextbranch and targetsnext, notmaster[kong])