Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kong] remove default securityContext #138

Merged
merged 1 commit into from
May 21, 2020
Merged

Conversation

rainest
Copy link
Contributor

@rainest rainest commented May 21, 2020

What this PR does / why we need it:

Removes the default security context (which ran the container as UID 1000). This does not appear to be necessary and removing it improves compatibility with OpenShift.

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the next branch and targets next, not master
  • New or modified sections of values.yaml are documented in the README.md
  • Title of the PR and commit headers start with chart name (e.g. [kong])

Copy link
Member

@hbagdi hbagdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade guide should include a note for this (not in scope of this PR).

@rainest
Copy link
Contributor Author

rainest commented May 21, 2020

Shouldn't need it--there's no change in behavior with it gone, nor any harm leaving it in place if you already had it from an old values.yaml.

@rainest rainest merged commit 9763f9c into next May 21, 2020
@rainest rainest deleted the feat/security-default branch May 21, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants