Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kong] add servicemonitor targetLabels support #162

Merged
merged 1 commit into from
Jun 24, 2020
Merged

[kong] add servicemonitor targetLabels support #162

merged 1 commit into from
Jun 24, 2020

Conversation

flabatut
Copy link
Contributor

related to prometheus-operator
serviceMonitor CRD capacity to transfer
kubernetes service labels to prometheus
when using targetLabels spec parameter
See https://tinyurl.com/yclly9xx for additional information

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the next branch and targets next, not master
  • New or modified sections of values.yaml are documented in the README.md
  • Title of the PR and commit headers start with chart name (e.g. [kong])

related to prometheus-operator
serviceMonitor CRD capacity to transfer
kubernetes service labels to prometheus
when using targetLabels spec parameter
See https://tinyurl.com/yclly9xx for additional information
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2020

CLA assistant check
All committers have signed the CLA.

@rainest rainest merged commit 461db8d into Kong:next Jun 24, 2020
@rainest
Copy link
Contributor

rainest commented Jun 24, 2020

@flabatut for the future, please avoid including unrelated changes (the controller version bump) in PRs, or separate them into atomic commits to keep history clear. That's useful for when we write the changelog later.

Went ahead and merged as-is since that change is small and should go into next anyway. However, tt's usually not necessary to PR them--we go through and bump up versions where needed during release prep, before we merge current next to master and create a new chart version.

@hbagdi
Copy link
Member

hbagdi commented Jun 24, 2020

Thank you for your contribution. Please fill out the following form to claim your contributor swag:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt.

@flabatut flabatut deleted the feat/targetLabels branch June 25, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants