Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kong] define KONG_PORT_MAPS for the proxy service #169

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Conversation

mflendrich
Copy link
Member

@mflendrich mflendrich commented Jul 5, 2020

What this PR does / why we need it:

Defines KONG_PORT_MAPS for the proxy service.
Before this PR, a request coming to the proxy service on port 80 would get X-Forwarded-Port: 8000 (and equivalent for https).
After this PR, a request coming to the proxy service on port 80 would get X-Forwarded-Port: 80 (and equivalent for https).

Makes use of the new feature introduced in Kong/kong#5861.
This PR makes a fix equivalent to Kong/kubernetes-ingress-controller#691, but for a different deployment method.

Which issue this PR fixes

fixes #168

Special notes for your reviewer:

Note that KONG_PORT_MAPS get defined only for the proxy service.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the next branch and targets next, not master
  • Title of the PR and commit headers start with chart name (e.g. [kong])

@mflendrich mflendrich requested a review from rainest July 5, 2020 16:23
@mflendrich mflendrich requested a review from hbagdi as a code owner July 5, 2020 16:23
@mflendrich mflendrich added bug Something isn't working please review labels Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants