Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kong] add support for sidecar containers #174

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

dsem
Copy link
Contributor

@dsem dsem commented Jul 23, 2020

What this PR does / why we need it:

Adds support for arbitrary sidecar containers to the Deployment resource.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the next branch and targets next, not master
  • New or modified sections of values.yaml are documented in the README.md
  • Title of the PR and commit headers start with chart name (e.g. [kong])

@dsem dsem requested review from hbagdi and rainest as code owners July 23, 2020 02:11
@CLAassistant
Copy link

CLAassistant commented Jul 23, 2020

CLA assistant check
All committers have signed the CLA.

@dsem dsem force-pushed the support-sidecar-containers branch from bf6aae8 to 93ae7e8 Compare July 23, 2020 02:11
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! This is a good flexible approach to doing what I currently do with debug branches (see ce1b952 for an example) in a way that's much easier to utilize in practice (forking and adding one's own template changes is no fun).

One minor change request to point users to the relevant K8S object reference doc. Sadly no way to not pin that to a specific version yet, but that's a fairly minor concern--I'm fine pointing that to current latest/v18 and leaving it up to readers to figure out if they need to change to an older or newer version.

charts/kong/values.yaml Show resolved Hide resolved
Co-authored-by: Travis Raines <raines.travis@gmail.com>
@dsem
Copy link
Contributor Author

dsem commented Jul 23, 2020

Thanks for the feedback and so glad you'll find it helpful too!

@dsem dsem requested a review from rainest July 23, 2020 19:36
@rainest
Copy link
Contributor

rainest commented Jul 24, 2020

Passes all practical testing on my end! :shipit:

Thank you for your contribution. Please fill out the following form to claim your contributor swag:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt.

@rainest rainest merged commit 4e36546 into Kong:next Jul 24, 2020
@dsem dsem deleted the support-sidecar-containers branch July 25, 2020 00:38
@hbagdi
Copy link
Member

hbagdi commented Sep 11, 2020

Thank you for your contribution. Please fill out the following form to claim your contributor swag:
https://github.com/Kong/kong/blob/master/CONTRIBUTING.md#contributor-t-shirt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants