-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kong] add support for sidecar containers #174
Conversation
bf6aae8
to
93ae7e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! This is a good flexible approach to doing what I currently do with debug branches (see ce1b952 for an example) in a way that's much easier to utilize in practice (forking and adding one's own template changes is no fun).
One minor change request to point users to the relevant K8S object reference doc. Sadly no way to not pin that to a specific version yet, but that's a fairly minor concern--I'm fine pointing that to current latest/v18 and leaving it up to readers to figure out if they need to change to an older or newer version.
Co-authored-by: Travis Raines <raines.travis@gmail.com>
Thanks for the feedback and so glad you'll find it helpful too! |
Passes all practical testing on my end! Thank you for your contribution. Please fill out the following form to claim your contributor swag: |
Thank you for your contribution. Please fill out the following form to claim your contributor swag: |
What this PR does / why we need it:
Adds support for arbitrary sidecar containers to the Deployment resource.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
next
branch and targetsnext
, notmaster
[kong]
)