-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namespace to generated manifests #193
Add namespace to generated manifests #193
Conversation
Hey, more places to tag @eskibars ! This hits a vein similar to the end of Kong/kubernetes-ingress-controller#844 (review), where we have most of our more complex tooling in this Helm chart, but have some users that don't want all of Helm's overhead. Chart modifications to support Helm use via I've historically been reticent to add documentation or template functionality targeted at @mdostal-hci though this doesn't relate to the PR content itself, you're a demonstrably good person to ask know that we know you do use the chart that way: what other stumbling blocks have you encountered, if any? In particular, how do you handle migration jobs? Do you find that you need to do much beyond provide Side note: approving but not merging yet--mostly just keeping this open because I'm interested in the broader discussion between |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As Travis said, we don't have a lot of feedback from users who do the helm template
workflow. We are happy to incorporate such improvements and even document it further if that helps the community.
Meh, go figure, other PR created conflicts. Merged manually in 700d287 to avoid anything similar going forward. We'll keep the stuff for product management in mind, as we have other open tickets for that elsewhere. |
What this PR does / why we need it:
It explicitely adds namespace to generated manifests (e.g. by
helm template
), not to rely on automated Helm inclusion. See #192 for more detail.Which issue this PR fixes
fixes #192
Special notes for your reviewer:
Checklist
next
branch and targetsnext
, notmain
[kong]
)