[kong] fix autoscaling and replicaCount conflict #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever the deployment is updated the number of pods is scaled down to replicaCount, even though autoscaling is enabled. Related issue: kubernetes/kubernetes#25238.
|
|
mflendrich
requested changes
Nov 2, 2020
There was a problem hiding this comment.
Thanks for this contribution.
Please also edit the comment at
charts/charts/kong/values.yaml
Line 469 in 19b5ebe
autoscaling.enabled is set to true. Same for Line 466 in 19b5ebe
mflendrich
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Whenever the deployment is updated the number of pods is scaled down to replicaCount, even though autoscaling is
enabled. Related issue: kubernetes/kubernetes#25238.
Checklist
nextbranch and targetsnext, notmain[kong])