[kong] add nodeSelector to migration Jobs #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mflendrich
reviewed
Dec 11, 2020
| @@ -58,6 +58,10 @@ spec: | |||
| {{- include "kong.volumeMounts" . | nindent 8 }} | |||
| securityContext: | |||
| {{- include "kong.podsecuritycontext" . | nindent 8 }} | |||
| {{- if .Values.nodeSelector }} | |||
| nodeSelector: | |||
| {{ toYaml .Values.nodeSelector | indent 8 }} | |||
There was a problem hiding this comment.
Before this PR, all 3 edited files prefer nindent (with {{-) to indenting - this PR appears to be the first introduction of indent.
Is there a rationale for breaking consistency? If not, could we do:
Suggested change
| {{ toYaml .Values.nodeSelector | indent 8 }} | |
| {{- toYaml .Values.nodeSelector | nindent 8 }} |
throughout this PR?
There was a problem hiding this comment.
Not really. Copy-pasta from the deployment template; newline-chomping convention isn't consistent throughout the templates.
mflendrich
approved these changes
Dec 14, 2020
It's manual since we don't have an exhaustive test values.yaml with all non-default settings. I set it to an example value to confirm that the indentation is correct/didn't result in invalid Job resources rendering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The nodeSelector value was previously only applied to the main Deployment. It should be applied to migration Jobs also, since they run Kong also, and have the same platform requirements.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
nextbranch and targetsnext, notmain[kong])