Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kong] able to configure resources for all containers #294

Merged
merged 2 commits into from
Feb 24, 2021

Conversation

zjheyvc
Copy link
Contributor

@zjheyvc zjheyvc commented Feb 24, 2021

What this PR does / why we need it:

Adds configurable block of resources for migrations containers when are needed to use, useful when use namespaces with quotas.

Also, Inherit resources from Kong pods for others containers to this approach

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the next branch and targets next, not main
  • New or modified sections of values.yaml are documented in the README.md
  • Title of the PR and commit headers start with chart name (e.g. [kong])

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
All committers have signed the CLA.

@rainest rainest changed the base branch from main to next February 24, 2021 18:11
@rainest
Copy link
Contributor

rainest commented Feb 24, 2021

@julianvelizc and @zjheyvc can you sign the CLA? Code changes look good, so once that's signed we can merge it in.

@zjheyvc
Copy link
Contributor Author

zjheyvc commented Feb 24, 2021

@julianvelizc and @zjheyvc can you sign the CLA? Code changes look good, so once that's signed we can merge it in.

Hello @rainest , I did signed with @zjheyvc but I think with my another account is not possible to connect to github to signed it license, what can I do continue in this case?

@zjheyvc
Copy link
Contributor Author

zjheyvc commented Feb 24, 2021

If is not possible, we can close this PR and I will send another just with my active user @rainest

@rainest
Copy link
Contributor

rainest commented Feb 24, 2021

You'll want to re-author the commits to your zjheyvc user following https://www.git-tower.com/learn/git/faq/change-author-name-email/

After that force-pushing the branch should fix this PR.

@zjheyvc zjheyvc force-pushed the chore/resources-for-all-containers branch from 3bb6768 to c22cdae Compare February 24, 2021 20:22
@zjheyvc
Copy link
Contributor Author

zjheyvc commented Feb 24, 2021

@rainest its done!

@rainest rainest merged commit e85244b into Kong:next Feb 24, 2021
rainest pushed a commit that referenced this pull request Mar 1, 2021
* chore: wait-for-db inherit the Kong container resources

* chore: added resources block to migrations settings to use in migration and wait-for-postgres containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement requests/limits for all containers
3 participants