[kong] add SAN to generated webhook certificate #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a SAN equal to the common name to the generated webhook certificate. As of Go 1.15, certificates that contain a hostname CommonName and no SubjectAlternativeName are considered invalid: https://golang.org/cl/243221 Current versions of KIC use Go 1.15.
shaneutt
approved these changes
Mar 11, 2021
rainest
added a commit
that referenced
this pull request
Mar 11, 2021
Add a SAN equal to the common name to the generated webhook certificate. As of Go 1.15, certificates that contain a hostname CommonName and no SubjectAlternativeName are considered invalid: https://golang.org/cl/243221 Current versions of KIC use Go 1.15.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a SAN equal to the common name to the generated webhook certificate.
As of Go 1.15, certificates that contain a hostname CommonName and no
SubjectAlternativeName are considered invalid:
https://golang.org/cl/243221
Current versions of KIC use Go 1.15 and will complain without this.
Special notes for your reviewer:
Ref http://masterminds.github.io/sprig/crypto.html#gensignedcert for the syntax.
Once in next, we should cherry-pick into a 1.15.1 release also.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
nextbranch and targetsnext, notmain[kong])