Helm custom labels (#369) #370
Conversation
Provide the support for global custom labels.
|
|
fix typo.
Co-authored-by: Michał Flendrich <m.flendrich@gmail.com>
Update according feedback.
Fix typo.
|
@mflendrich I got one another issue to fix, so what is the process for merging this PR ? Thanks ! |
|
@ludovic-pourrat there's currently some conflict between it and current next that blocks the merge. You'll want to update your copy of next with upstream changes, merge next into your branch, fix conflicts that occur during the merge, and then push the result. |
|
@rainest fork up-to-date mow. Thanks. |
|
|
||
| ```yaml | ||
| extraLabels: | ||
| acme.com/some-key: some-value |
There was a problem hiding this comment.
would suggest using format
acme.com/some-key: "{{.value}}"
|
Ah the damn Github UI was complaining about rebase merge mode only. That should probably have some UI indicator that a squash merge won't cause conflicts :| no matter. Thank you for your contribution. Please fill out the following form to claim your contributor swag: |
Provide the support for global custom labels.