[kong] use args instead of command #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use args instead of command for containers that do not run the standard image command (wait-for-db and migrations). Standard Kong images built with https://github.com/Kong/docker-kong use an entrypoint script. This script performs some initial bootstrap setup and then executes whatever command was provided to Docker. Kubernetes' handling of the ENTRYPOINT/CMD relationship differs from Docker's. Docker always runs the image entrypoint, passing the command as arguments to it. Kubernetes "command" in container templates instead overrides the entrypoint entirely: https://kubernetes.io/docs/tasks/inject-data-application/define-command-argument-container/#notes We do want the entrypoint to run normally, because in some images it injects bundled custom plugins into KONG_PLUGINS. Additionally update the wait-for-db command to include an override KONG_NGINX_DAEMON value inline. The stock entrypoint hardcodes this off, which we don't want, and must override for wait-for-db.
|
fyi: PR Kong/docker-kong#474 has been merged |
|
@rainest will this work backward compatible? The fix in Kong/docker-kong#474 shows that old images will ALWAYS set the daemonize option to off. So even if you pass the env var in, the entrypoint will override it again and set it to off again. Not sure how to fix this.... |
|
The export there will run after the one in the entrypoint script. CI would fail otherwise (since the initcontainer would never complete). |
shaneutt
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Uses
argsinstead ofcommandto invoke non-standard commands for Kong containers. This allows the standard image entrypoint to run rather than replacing it.Inject the no daemonize environment variable directly into the wait-for-db command. There's currently a limitation in the entrypoint that overrides the container environment. Kong/docker-kong#474 intends to fix it but we'll need this for backwards compatibility.
See the commit message for a bit more detail on why we need this.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
nextbranch and targetsnext, notmain[kong])