Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kong] Admission controller setup #380 #384

Merged
merged 1 commit into from
Jun 24, 2021
Merged

[kong] Admission controller setup #380 #384

merged 1 commit into from
Jun 24, 2021

Conversation

ludovic-pourrat
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the next branch and targets next, not main
  • New or modified sections of values.yaml are documented in the README.md
  • Title of the PR and commit headers start with chart name (e.g. [kong])

@ludovic-pourrat
[kong] Admission controller setup Kong#380
34cd316 
Move port definition from the deployment to the ingress controller.
@ludovic-pourrat ludovic-pourrat requested a review from a team as a code owner June 24, 2021 20:28
@rainest rainest merged commit cfb31d2 into Kong:next Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainest rainest rainest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ludovic-pourrat @rainest