Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kong] fix daemonset values key #426

Merged
merged 1 commit into from
Jul 29, 2021
Merged

[kong] fix daemonset values key #426

merged 1 commit into from
Jul 29, 2021

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Jul 29, 2021 •
edited

What this PR does / why we need it:

The daemonset toggle was previously at deployment.kong.daemonset. The templates expected deployment.daemonset, and placing this toggle directly under deployment is semantically correct (it affects the entire deployment, not just the Kong container).

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the next branch and targets next, not main
  • New or modified sections of values.yaml are documented in the README.md
  • Title of the PR and commit headers start with chart name (e.g. [kong])

@rainest
[kong] fix daemonset values key
3008da4 
Move the daemonset toggle from deployment.kong.daemonset to
deployment.daemonset. Templates were looking for the latter key. It was
originally added to the wrong location in values.yaml.
@rainest rainest requested a review from a team as a code owner July 29, 2021 16:31
@rainest rainest mentioned this pull request Jul 29, 2021
Closed
ccfishk
ccfishk approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@ccfishk ccfishk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ccfishk ccfishk merged commit b9d8856 into next Jul 29, 2021
@ccfishk ccfishk deleted the fix/daemonset-key branch July 29, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccfishk ccfishk ccfishk approved these changes

Assignees
No one assigned
Labels
please review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rainest @ccfishk