[kong] use latest available Ingress version

[rainest]

What this PR does / why we need it:

Add support for networking.k8s.io/v1beta1 and networking.k8s.io/v1
Ingress resources. Generate Ingress resources with the newest available
version on the cluster.

Add support for the ingressClassName field and IngressClass resource.

We need Ingress v1 support for 1.22. These are fairly recent, however, so instead of blanket changes to v1, this auto-detects the latest available version and creates resources according.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

• fixes Generated Ingresses still use extensions/v1beta1 #444

Special notes for your reviewer:

Does anyone know of a local K8S environment <1.18 that still works? KIND and Minikube are both failing to start for me on 1.17 and 1.16 images, and I can't find related issues with a fix in those projects.

I can force the extensions content to render with invalid versions:

diff --git a/charts/kong/templates/_helpers.tpl b/charts/kong/templates/_helpers.tpl
index 268182f45..386ade324 100644
--- a/charts/kong/templates/_helpers.tpl
+++ b/charts/kong/templates/_helpers.tpl
@@ -1076,9 +1076,9 @@ Kubernetes resources it uses to build Kong configuration.
 {{- end -}}
 
 {{- define "kong.ingressVersion" -}}
-{{- if (.Capabilities.APIVersions.Has "networking.k8s.io/v1") -}}
+{{- if (.Capabilities.APIVersions.Has "anetworking.k8s.io/v1") -}}
 networking.k8s.io/v1
-{{- else if (.Capabilities.APIVersions.Has "networking.k8s.io/v1beta1") -}}
+{{- else if (.Capabilities.APIVersions.Has "anetworking.k8s.io/v1beta1") -}}
 networking.k8s.io/v1beta1
 {{- else -}}
 extensions/v1beta1

Which makes helm template trk /tmp/symkong -f ~/src/charts/charts/kong/example-values/minimal-kong-controller.yaml --set admin.enabled=true --set admin.ingress.enabled=true > /tmp/fakeold.yaml render fakeold.yaml.txt

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

• PR is based off the current tip of the next branch and targets next, not main
• New or modified sections of values.yaml are documented in the README.md
• Title of the PR and commit headers start with chart name (e.g. [kong])

[ccfishk]

lgtm

[shaneutt]

I would ask that we add some integration tests for this functionality, and then 👍

[Nica-Alex]

This is not working with my 1.18 cluster: no matches for kind "Ingress" in version "networking.k8s.io/v1"
I think your condition

{{- if (.Capabilities.APIVersions.Has "networking.k8s.io/v1") -}}
 networking.k8s.io/v1
 {{- else if (.Capabilities.APIVersions.Has "networking.k8s.io/v1beta1") -}}
 networking.k8s.io/v1beta1
 {{- else -}}
 extensions/v1beta1
 {{- end -}}

is wrong, as k8s 1.18 has networking.k8s.io/v1 but it doesn't contain Ingress until 1.19.

This is what I had to do in one of my charts:

{{- if semverCompare ">=1.19-0" .Capabilities.KubeVersion.Version -}}
apiVersion: networking.k8s.io/v1
{{- else if semverCompare ">=1.14-0, <1.19-0" .Capabilities.KubeVersion.Version -}}
apiVersion: networking.k8s.io/v1beta1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}

Check this issue here.

[robincher]

Hi,

Upon installing kong ingress controller, i run 'kubectl get ingressclass ", but for some reasons i am unable to find the corresponding ingress class for kong. I guess this Pull Request will address the issue i encountered?

#values.yaml
 ingressController:
      enabled: true
      ingressClass: kong

[rainest]

@robincher this is a completed PR. We don't normally track new comments on these. Please file an issue, ask a question in the #kong Kubernetes Slack channel, or make a post in Kong Nation in the future.

https://github.com/Kong/charts/pull/446/files#diff-1f3f47b958cb61ddd4f0d4a7882b8ebbe64b9771e80f4b76cd94bc327a30f107 should create one if you're on a version that supports it, but part of the check was backwards, so #485