[kong] move ServiceAccount configuration #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
fork/ludovic-pourrat-next
branch
4 times, most recently
from
8f991da
to
24d185c
Compare
|
@rainest what isthe specific use for CI that wasn't fulfilled by our existing triggers? Consider filing an |
|
It's just on PRs rather than branches, which makes sense for the vast majority of chart stuff. This one was a bit weird since I needed to make a new PR to test out my changes on top of stuff that originated from a fork. |
…#418) Add the feature to create a service account for the deployment and the migrations
…#418) fix trailing spaces.
…#418) Fix defaulting to previous definition.
Move the ServiceAccount configuration from under ingressController to under deployment. Always create the ServiceAccount by default, even if no permissions are assigned and it is not used by other resources in the chart. Add warnings indicating that configuration has moved if the ingressController.serviceAccount section set any non-default (empty) values. Mount the ServiceAccount token if the ServiceAccount exists. Disabling the ServiceAccount entirely disables mounting the default ServiceAccount token.
rainest
force-pushed
the
fork/ludovic-pourrat-next
branch
from
24d185c
to
75c5014
Compare
rainest
changed the title
|
Ignore the prior conversation, this is a real PR and should be reviewed now. |
Co-authored-by: Shane Utt <shaneutt@linux.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow creation and configuration of ServiceAccounts independent of the controller. By default, always create a ServiceAccount, changing it from a default conditional (if controller or PSP in use) on to just default on. Fix #418
Originally a user PR, but didn't hear back after the request to reopen in #418 (comment). Opening my own since I'd like this to go in before the next release, which is imminent.