Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kong] Fix disabling KongClusterPlugin controller environment variable. #475

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

johnharris85
Copy link
Contributor

Signed-off-by: John Harris john.harris@konghq.com

What this PR does / why we need it:

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
When deploying KIC with watchNamespaces set, the chart sets an incorrect environment variable so the KongClusterPlugin controller is not disabled, causing a CrashLoopBackOff.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the next branch and targets next, not main
  • New or modified sections of values.yaml are documented in the README.md
  • Title of the PR and commit headers start with chart name (e.g. [kong])

Signed-off-by: John Harris <john.harris@konghq.com>
@johnharris85 johnharris85 requested a review from a team as a code owner October 19, 2021 15:36
@CLAassistant
Copy link

CLAassistant commented Oct 19, 2021

CLA assistant check
All committers have signed the CLA.

Signed-off-by: John Harris <john.harris@konghq.com>
@rainest
Copy link
Contributor

rainest commented Oct 19, 2021

LGTM. While this is awaiting release, please set env.ingressController.enable_controller_kongclusterplugin=false manually to work around the issue.

@rainest rainest merged commit 70e11bf into Kong:next Oct 19, 2021
rainest pushed a commit that referenced this pull request Oct 19, 2021
Fix KongClusterPlugin controller env var.

Signed-off-by: John Harris <john.harris@konghq.com>
@johnharris85 johnharris85 deleted the fix-kcp-watch-ns branch October 22, 2021 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants