Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply the SecurityContext to the PID removal initContainer #503

Merged
merged 2 commits into from
Nov 30, 2021
Merged

Apply the SecurityContext to the PID removal initContainer #503

merged 2 commits into from
Nov 30, 2021

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Nov 30, 2021

What this PR does / why we need it:

This should be the same as the proxy container, but was omitted earlier.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

@rainest rainest requested a review from a team as a code owner November 30, 2021 01:35
@KongCarl
Copy link

Can we ensure the init Container also respects the resources: {} section?

shaneutt
shaneutt approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure @KongCarl's comment gets resolution and then LGTM 👍

@rainest rainest merged commit f56c5d2 into next Nov 30, 2021
@rainest rainest deleted the fix/pid-sec branch November 30, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rainest @KongCarl @shaneutt