fix(init) rework wait-for-db socket workaround #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a temporary prefix directory for wait-for-db instead of removing problem files. For unclear reasons, versions of Kong that should include https://trac.nginx.org/nginx/ticket/753 are still leaving old socket files behind in the prefix after wait-for-db completes. Additional sockets in newer Kong versions result in a new variant of #295, preventing startup when using Postgres. Since we don't actually need anything wait-for-db writes to the prefix, we can write to a temporary prefix instead to avoid this class of issue entirely.
This was referenced Dec 1, 2021
shaneutt
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
This seems like a reasonable way to deal with the problem to me. I can't think of any gotchas for this, and given that it's for the wait-for-db container where the end-user is highly unlikely to need to do anything in the prefix directory I feel confident about it.
I would only say maybe give this a couple more cycles and some extra special care testing, but LGTM ✔️
|
Effectively it's just starting Kong from a clean slate same as it would in DB-less mode. Existing tests are fine for this since any issue with it would prevent the Postgres-backed instance from starting at all (either wait-for-db would never succeed or proxy would try to start in some environment where that was impossible). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use a temporary KONG_PREFIX for wait-for-db, rather than using the standard prefix and removing leftover files. This avoids the general class of issue described in #295. As that issue is still present on versions of Kong after 2.3, it looks like we'll need to keep the workaround indefinitely, unless we can figure out why we're still leaking socket files despite the upstream fix.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Found while testing the 2.7 nightly. This adds an additional socket (and somehow makes the existing
rmnot work): Kong/kubernetes-testing-framework#168 (comment)Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
nextbranch and targetsnext, notmain