preStop: Replace sleep with --wait #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
previously approved these changes
Jan 20, 2022
rainest
requested changes
Jan 20, 2022
The `kong quit` command has the ability to do the sleep itself which is cleaner and provides better logging (should we choose to capture it): - https://github.com/Kong/kong/blob/2.6.0/kong/cmd/quit.lua#L59-L72 - https://github.com/Kong/kong/blob/2.6.0/kong/cmd/quit.lua#L20-L33
dcarley
force-pushed
the
dcarley/prestop-kong-quit-wait
branch
from
88d258d
to
59beb60
Compare
rainest
approved these changes
Jan 21, 2022
ubergesundheit
pushed a commit
to giantswarm/kong-charts-upstream
that referenced
this pull request
Feb 9, 2022
The `kong quit` command has the ability to do the sleep itself which is cleaner and provides better logging (should we choose to capture it): - https://github.com/Kong/kong/blob/2.6.0/kong/cmd/quit.lua#L59-L72 - https://github.com/Kong/kong/blob/2.6.0/kong/cmd/quit.lua#L20-L33 Co-authored-by: Travis Raines <571832+rainest@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
kong quitcommand has the ability to do the sleep itself which iscleaner and provides better logging (should we choose to capture it):
Which issue this PR fixes
N/A
Special notes for your reviewer:
We've been testing this because the wait needs to be increased when using NLBs.
I've only quoted the last argument because it has more chance of falling foul of YAML intepretation.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.