Add Gateway RBAC and tests #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaneutt
reviewed
Jan 24, 2022
rainest
force-pushed
the
feat/gateway
branch
7 times, most recently
from
72cbac1
to
b5cd454
Compare
rainest
force-pushed
the
feat/gateway
branch
2 times, most recently
from
9ef1798
to
3ec1a8e
Compare
Move tests from non-main workflow into main PR workflow and remove non-main workflow. Remove 1.x -> 2.x transitional tests.
Always run chart-testing even if no changes are detected. An unknown issue is preventing ct list-changed from detecting changes.
shaneutt
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds Gateway RBAC and tests.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Notes for reviewers
CI was a combination of misconfigured and broken after the removal of next. Integration tests have moved into the main PR workflow. chart-testing is being very annoying and reporting that there are no changes even though running it locally says there are. I don't much care to dig into this ATM, since for our purposes we only have the single chart, almost all changes update it, and simply running tests on everything always is generally fine (the change detection stuff was more relevant on the old helm/charts repo, which had ALL the charts and only changed one in any given PR).
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.