Remove dedicated Portal auth configuration from values.yaml #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* Remove enterprise.portal.portal_auth and enterprise.portal.session_conf_secret from values.yaml. Both can be configured per-workspace in Kong Manager, and providing them via environment variables only provides defaults. The standard default values are fine; Manager will prompt users to create a session configuration if necessary. * Add deprecation warning to NOTES.txt. The chart continues to apply the old settings if present, but warns users that they should remove them or migrate them to env values. * Update README.md with new session instructions. * Clean up some outdated comments from values.yaml and adjust NOTES.txt format a bit.
rainest
force-pushed
the
fix/portal-auth-removal
branch
from
2c37339
to
c949a69
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Remove the dedicated Portal auth/session configuration. These are not necessary for most versions, as Kong Enterprise will start fine without them and allows users to set them via a workspace's Portal configuration in Manager.
This change continues support for the existing configuration to maintain compatibility with existing user values.yamls. It places a warning in NOTES.txt to inform users that the configuration is deprecated and should be moved under
envif they wish to keep it in place.Which issue this PR fixes
Fix #52
Special notes for your reviewer:
Unlike other versions, 0.35 does not support configuring sessions via Manager: the kong.conf
portal_session_confis the only way to set Portal session configuration, and is used by all workspaces. Setting this inenvor continuing to use the deprecated configuration works for 0.35.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
nextbranch and targetsnext, notmaster[kong])