Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(conf) fix creation of non-default IngressClasses #552

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

ONordander
Copy link
Contributor

@ONordander ONordander commented Feb 23, 2022

When using a custom IngressClass we should check for existence of that class, not the default 'kong' one.

What this PR does / why we need it:

If a user wants to have two Kong instances installed with different IngressClasses the second installation will not actually create the IngressClass since it checks for the existence of the 'kong' IngressClass.

Special notes for your reviewer:

Tested with:

ingressController:
  ingressClass: test-kong

and
helm template --validate -f values.yaml kong -n kong .

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • Commits follow the Kong commit message guidelines

@ONordander ONordander requested a review from a team as a code owner February 23, 2022 11:56
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022

CLA assistant check
All committers have signed the CLA.

When using a non-default IngressClass we should check for
existence of that class, not the default 'kong' one.
@ONordander ONordander force-pushed the fix/custom-ingress-class-creation branch from cabf734 to 9801ade Compare February 23, 2022 11:57
Copy link
Member

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, would also like a double check from @rainest

@rainest rainest merged commit 4f49605 into Kong:main Feb 23, 2022
@ONordander ONordander deleted the fix/custom-ingress-class-creation branch February 23, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants