fix(helpers) disable keyring in wait-for-db container #556
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The wait-for-db container checks for migration readiness. Since
it starts the full kong cluster, it also runs keyring bootstrap process:
the kong clster in that container generates the initial key,
store in its memory, and writes the key_id to keyring_meta table.
But it doesn’t have enough time to broadcast its key to other kong
container that serves proxy, admin, manager etc. By design,
keyring doesn't automatically generate a new key if there's
anything in the keyring_meta table, even no nodes have
knowledge to it; this it to avoid unnecessary rotation of keys.
This PR skips keyring bootstrap at wait-for-db container, so the
bootstrap can be done in an actual kong cluster.
Which issue this PR fixes
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.