feat(services) add Ingress for cluster sync #583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is an alternative pull request to #573 . This one uses the default Ingress feature of K8s to create OpenShift routes. I just need to add Ingress option for cluster communication as well, that's why I edited the matching service templates. I need this for automatic creation of OpenShift routes as I need them for cluster to cluster communication between CP and DP.
I also had to remove an unnecessary if statement, because ingress.path already has a default value in values.yml. I need the option to be able to leave the ingress.path blank.
Special notes for your reviewer:
As I said, this is an alternative to #573 and I would be happy if we could find a common solution here.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
main
branch.