Fix broken newline chomp in Kong NOTES.txt #66
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I missed part of the fix in #38 earlier 🤦♀️
The original template chomped the newline before
export PROXY_IP=${HOST}:${PORT}
, causing it to render asPORT=$(kubectl get svc --namespace default skulking-moose-kong-proxy -o jsonpath='{.spec.ports[0].nodePort}')export PROXY_IP=${HOST}:${PORT}
, which doesn't work very well.Checklist
next
branch and targetsnext
, notmaster
[kong]
)