fix(hpa) properly detect hpa capabilities, release 2.16.4 #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
slavogiez
force-pushed
the
fix/hpa-api-versions-detection
branch
from
1fd2a2f
to
e207d38
Compare
slavogiez
changed the title
czeslavo
changed the title
czeslavo
approved these changes
Feb 14, 2023
|
Hey @slavogiez 👋 Thank you for the contribution! 🎖️ Let's just wait for the pipelines to complete and we'll release 2.16.4 with your patch. |
|
Awesome! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When using ArgoCD to deploy Kong gateway using this Helm chart, the HorizontalPodAutoscaler api version is not well detected : on k8s 1.22, Argocd tries to use the autoscaling/v2 but it is not available, so it fails to deploy.
This fix is similar to this one: elastic/helm-charts#1684
This bug seems to have been introduced by #679
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.