Webhook validation labels #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rainest
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Looks reasonable. @minfeng-chan can you add a changelog entry and sign the CLA? That should be all we need to merge this.
Edit: there are also some minor whitespace issues that are making the linter angry.
|
Hi rainest, edited as per your comment. Thanks. |
czeslavo
approved these changes
Mar 31, 2023
rainest
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adds label to the validation webhook.
This is necessary for certain use cases such as integrating with Consul.
For consul we will need to add the following:
consul.hashicorp.com/service-ignore: "true"
Which issue this PR fixes
NIL
Special notes for your reviewer:
NIL
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.