GRPCRoute RBACs added to KIC
#772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlavacca
force-pushed
the
mlavacca/grpcroute-rbacs
branch
from
43da53c
to
943bb5c
Compare
pmalek
reviewed
Mar 21, 2023
There was a problem hiding this comment.
Do you mind bumping the rc version in https://github.com/Kong/charts/blob/main/charts/kong/Chart.yaml#L14 so that we get this out and people can keep testing?
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
mlavacca
force-pushed
the
mlavacca/grpcroute-rbacs
branch
from
943bb5c
to
b880e8d
Compare
pmalek
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
KIC is going to support GRPCRoute with the upcoming 2.9 version. We need to update the RBACs in the chart as well.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.